commit f5c6001603da65efffb1136f5566340c3f082193
author Antonio Nino Diaz <antonio.ninodiaz@arm.com> Mon Jul 16 23:36:10 2018 +0100
committer Antonio Nino Diaz <antonio.ninodiaz@arm.com> Tue Jul 24 09:19:22 2018 +0100
tree 1e4a1e3129b039968e83c4292f02450777c04a20
parent 56a0e8ef1e0f88c372d083caff208250ac270b7a

PSCI: Fix MISRA defects in MEM_PROTECT

MISRA C-2012 Rules 10.1 and 10.3.

Change-Id: I88cd5f56cda5780f2e0ba541c0f5b561309ab3af
Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com>

lib/psci/psci_mem_protect.c

diff --git a/lib/psci/psci_mem_protect.c b/lib/psci/psci_mem_protect.c
index fca84e9..857146b 100644
--- a/lib/psci/psci_mem_protect.c
+++ b/lib/psci/psci_mem_protect.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, ARM Limited and Contributors. All rights reserved.
+ * Copyright (c) 2017-2018, ARM Limited and Contributors. All rights reserved.
  *
  * SPDX-License-Identifier: BSD-3-Clause
  */
@@ -9,30 +9,31 @@
 #include <utils.h>
 #include "psci_private.h"
 
-int psci_mem_protect(unsigned int enable)
+u_register_t psci_mem_protect(unsigned int enable)
 {
 	int val;
 
-	assert(psci_plat_pm_ops->read_mem_protect);
-	assert(psci_plat_pm_ops->write_mem_protect);
+	assert(psci_plat_pm_ops->read_mem_protect != NULL);
+	assert(psci_plat_pm_ops->write_mem_protect != NULL);
 
 	if (psci_plat_pm_ops->read_mem_protect(&val) < 0)
-		return PSCI_E_NOT_SUPPORTED;
+		return (u_register_t) PSCI_E_NOT_SUPPORTED;
 	if (psci_plat_pm_ops->write_mem_protect(enable) < 0)
-		return PSCI_E_NOT_SUPPORTED;
+		return (u_register_t) PSCI_E_NOT_SUPPORTED;
 
-	return val != 0;
+	return (val != 0) ? 1U : 0U;
 }
 
-int psci_mem_chk_range(uintptr_t base, u_register_t length)
+u_register_t psci_mem_chk_range(uintptr_t base, u_register_t length)
 {
 	int ret;
 
-	assert(psci_plat_pm_ops->mem_protect_chk);
+	assert(psci_plat_pm_ops->mem_protect_chk != NULL);
 
-	if (length == 0 || check_uptr_overflow(base, length-1))
-		return PSCI_E_DENIED;
+	if ((length == 0U) || check_uptr_overflow(base, length - 1U))
+		return (u_register_t) PSCI_E_DENIED;
 
 	ret = psci_plat_pm_ops->mem_protect_chk(base, length);
-	return (ret < 0) ? PSCI_E_DENIED : PSCI_E_SUCCESS;
+	return (ret < 0) ?
+	       (u_register_t) PSCI_E_DENIED : (u_register_t) PSCI_E_SUCCESS;
 }

lib/psci/psci_private.h

diff --git a/lib/psci/psci_private.h b/lib/psci/psci_private.h
index ac99876..75f7d45 100644
--- a/lib/psci/psci_private.h
+++ b/lib/psci/psci_private.h
@@ -330,7 +330,7 @@
 			unsigned int power_state);
 
 /* Private exported functions from psci_mem_protect.c */
-int psci_mem_protect(unsigned int enable);
-int psci_mem_chk_range(uintptr_t base, u_register_t length);
+u_register_t psci_mem_protect(unsigned int enable);
+u_register_t psci_mem_chk_range(uintptr_t base, u_register_t length);
 
 #endif /* PSCI_PRIVATE_H */