fix(cert-create): key: Avoid having a temporary value for pkey in key_load
key->key and k will point to the same if PEM_read_PrivateKey
(pem_read_bio_key_decoder) succeeds. There is no need for the temporary
'k' pointer here.
Signed-off-by: Robin van der Gracht <robin@protonic.nl>
Change-Id: I219c49d331eb6dd7200b49b75d47fd66da3d82dd
diff --git a/tools/cert_create/src/key.c b/tools/cert_create/src/key.c
index 27ec979..dc953d7 100644
--- a/tools/cert_create/src/key.c
+++ b/tools/cert_create/src/key.c
@@ -192,15 +192,14 @@
int key_load(key_t *key, unsigned int *err_code)
{
FILE *fp;
- EVP_PKEY *k;
if (key->fn) {
/* Load key from file */
fp = fopen(key->fn, "r");
if (fp) {
- k = PEM_read_PrivateKey(fp, &key->key, NULL, NULL);
+ key->key = PEM_read_PrivateKey(fp, NULL, NULL, NULL);
fclose(fp);
- if (k) {
+ if (key->key) {
*err_code = KEY_ERR_NONE;
return 1;
} else {