rockchip: fixes typo and some bugs for suspend/resume tests
1. Remove the AP_PWROFF in ATF, should configure it in kernel.
2. Save and restore the PWMs pin/regs for suspend/resume.
3. The pmusgrf reset-hold bits needs to be released. since the
pmusgrf reset-hold bits needs to be held.
4. Configure the PMU power up/down cycles about delay 3ms.
5. With the MMIO register block as one big mapping.
6. Fix the build error with psci_entrypoint since PSCI lib updated.
Fixes the commit
9ec78bd ("rockchip: support the suspend/resume for rk3399").
Change-Id: I112806700bf433c87763aac23d22fa7e6a7f5264
diff --git a/plat/rockchip/rk3399/drivers/pmu/pmu.c b/plat/rockchip/rk3399/drivers/pmu/pmu.c
index e106211..72d71bf 100644
--- a/plat/rockchip/rk3399/drivers/pmu/pmu.c
+++ b/plat/rockchip/rk3399/drivers/pmu/pmu.c
@@ -747,9 +747,6 @@
BIT_WITH_WMSK(PMU_CLR_CORE_L_2GIC_HW) |
BIT_WITH_WMSK(PMU_CLR_GIC2_CORE_L_HW));
- mmio_write_32(PMUGRF_BASE + PMUGRF_GPIO1A_IOMUX,
- BIT_WITH_WMSK(AP_PWROFF));
-
slp_mode_cfg = BIT(PMU_PWR_MODE_EN) |
BIT(PMU_POWER_OFF_REQ_CFG) |
BIT(PMU_CPU0_PD_EN) |
@@ -778,18 +775,18 @@
mmio_setbits_32(PMU_BASE + PMU_WKUP_CFG4, BIT(PMU_GPIO_WKUP_EN));
mmio_write_32(PMU_BASE + PMU_PWRMODE_CON, slp_mode_cfg);
- mmio_write_32(PMU_BASE + PMU_SCU_L_PWRDN_CNT, CYCL_32K_CNT_MS(5));
- mmio_write_32(PMU_BASE + PMU_SCU_L_PWRUP_CNT, CYCL_32K_CNT_MS(5));
- mmio_write_32(PMU_BASE + PMU_SCU_B_PWRDN_CNT, CYCL_32K_CNT_MS(5));
- mmio_write_32(PMU_BASE + PMU_SCU_B_PWRUP_CNT, CYCL_32K_CNT_MS(5));
- mmio_write_32(PMU_BASE + PMU_CENTER_PWRDN_CNT, CYCL_32K_CNT_MS(5));
- mmio_write_32(PMU_BASE + PMU_CENTER_PWRUP_CNT, CYCL_32K_CNT_MS(5));
- mmio_write_32(PMU_BASE + PMU_WAKEUP_RST_CLR_CNT, CYCL_32K_CNT_MS(5));
- mmio_write_32(PMU_BASE + PMU_OSC_CNT, CYCL_32K_CNT_MS(5));
- mmio_write_32(PMU_BASE + PMU_DDRIO_PWRON_CNT, CYCL_32K_CNT_MS(5));
- mmio_write_32(PMU_BASE + PMU_PLLLOCK_CNT, CYCL_32K_CNT_MS(5));
- mmio_write_32(PMU_BASE + PMU_PLLRST_CNT, CYCL_32K_CNT_MS(5));
- mmio_write_32(PMU_BASE + PMU_STABLE_CNT, CYCL_32K_CNT_MS(5));
+ mmio_write_32(PMU_BASE + PMU_SCU_L_PWRDN_CNT, CYCL_24M_CNT_MS(3));
+ mmio_write_32(PMU_BASE + PMU_SCU_L_PWRUP_CNT, CYCL_24M_CNT_MS(3));
+ mmio_write_32(PMU_BASE + PMU_SCU_B_PWRDN_CNT, CYCL_24M_CNT_MS(3));
+ mmio_write_32(PMU_BASE + PMU_SCU_B_PWRUP_CNT, CYCL_24M_CNT_MS(3));
+ mmio_write_32(PMU_BASE + PMU_CENTER_PWRDN_CNT, CYCL_24M_CNT_MS(3));
+ mmio_write_32(PMU_BASE + PMU_CENTER_PWRUP_CNT, CYCL_24M_CNT_MS(3));
+ mmio_write_32(PMU_BASE + PMU_WAKEUP_RST_CLR_CNT, CYCL_24M_CNT_MS(3));
+ mmio_write_32(PMU_BASE + PMU_OSC_CNT, CYCL_32K_CNT_MS(3));
+ mmio_write_32(PMU_BASE + PMU_DDRIO_PWRON_CNT, CYCL_24M_CNT_MS(3));
+ mmio_write_32(PMU_BASE + PMU_PLLLOCK_CNT, CYCL_24M_CNT_MS(3));
+ mmio_write_32(PMU_BASE + PMU_PLLRST_CNT, CYCL_24M_CNT_MS(3));
+ mmio_write_32(PMU_BASE + PMU_STABLE_CNT, CYCL_24M_CNT_MS(3));
mmio_clrbits_32(PMU_BASE + PMU_SFT_CON, BIT(PMU_24M_EN_CFG));
mmio_write_32(PMU_BASE + PMU_PLL_CON, PLL_PD_HW);
@@ -807,6 +804,72 @@
mmio_clrbits_32(PMU_BASE + PMU_BUS_CLR, hw_idle);
}
+struct pwm_data_s pwm_data;
+
+/*
+ * Save the PWMs data.
+ */
+static void save_pwms(void)
+{
+ uint32_t i;
+
+ pwm_data.iomux_bitmask = 0;
+
+ /* Save all IOMUXes */
+ if (mmio_read_32(GRF_BASE + GRF_GPIO4C_IOMUX) & GPIO4C2_IOMUX_PWM)
+ pwm_data.iomux_bitmask |= PWM0_IOMUX_PWM_EN;
+ if (mmio_read_32(GRF_BASE + GRF_GPIO4C_IOMUX) & GPIO4C6_IOMUX_PWM)
+ pwm_data.iomux_bitmask |= PWM1_IOMUX_PWM_EN;
+ if (mmio_read_32(PMUGRF_BASE + PMUGRF_GPIO1C_IOMUX) &
+ GPIO1C3_IOMUX_PWM)
+ pwm_data.iomux_bitmask |= PWM2_IOMUX_PWM_EN;
+ if (mmio_read_32(PMUGRF_BASE + PMUGRF_GPIO0A_IOMUX) &
+ GPIO0A6_IOMUX_PWM)
+ pwm_data.iomux_bitmask |= PWM3_IOMUX_PWM_EN;
+
+ for (i = 0; i < 4; i++) {
+ /* Save cnt, period, duty and ctrl for PWM i */
+ pwm_data.cnt[i] = mmio_read_32(PWM_BASE + PWM_CNT(i));
+ pwm_data.duty[i] = mmio_read_32(PWM_BASE + PWM_PERIOD_HPR(i));
+ pwm_data.period[i] = mmio_read_32(PWM_BASE + PWM_DUTY_LPR(i));
+ pwm_data.ctrl[i] = mmio_read_32(PWM_BASE + PWM_CTRL(i));
+ }
+
+ /* PWMs all IOMUXes switch to the gpio mode */
+ mmio_write_32(GRF_BASE + GRF_GPIO4C_IOMUX, GPIO4C2_IOMUX_GPIO);
+ mmio_write_32(GRF_BASE + GRF_GPIO4C_IOMUX, GPIO4C6_IOMUX_GPIO);
+ mmio_write_32(PMUGRF_BASE + PMUGRF_GPIO1C_IOMUX, GPIO1C3_IOMUX_GPIO);
+ mmio_write_32(PMUGRF_BASE + PMUGRF_GPIO0A_IOMUX, GPIO0A6_IOMUX_GPIO);
+}
+
+/*
+ * Restore the PWMs data.
+ */
+static void restore_pwms(void)
+{
+ uint32_t i;
+
+ /* Restore all IOMUXes */
+ if (pwm_data.iomux_bitmask & PWM3_IOMUX_PWM_EN)
+ mmio_write_32(PMUGRF_BASE + PMUGRF_GPIO0A_IOMUX,
+ GPIO0A6_IOMUX_PWM);
+ if (pwm_data.iomux_bitmask & PWM2_IOMUX_PWM_EN)
+ mmio_write_32(PMUGRF_BASE + PMUGRF_GPIO1C_IOMUX,
+ GPIO1C3_IOMUX_PWM);
+ if (pwm_data.iomux_bitmask & PWM1_IOMUX_PWM_EN)
+ mmio_write_32(GRF_BASE + GRF_GPIO4C_IOMUX, GPIO4C6_IOMUX_PWM);
+ if (pwm_data.iomux_bitmask & PWM0_IOMUX_PWM_EN)
+ mmio_write_32(GRF_BASE + GRF_GPIO4C_IOMUX, GPIO4C2_IOMUX_PWM);
+
+ for (i = 0; i < 4; i++) {
+ /* Restore ctrl, duty, period and cnt for PWM i */
+ mmio_write_32(PWM_BASE + PWM_CTRL(i), pwm_data.ctrl[i]);
+ mmio_write_32(PWM_BASE + PWM_DUTY_LPR(i), pwm_data.period[i]);
+ mmio_write_32(PWM_BASE + PWM_PERIOD_HPR(i), pwm_data.duty[i]);
+ mmio_write_32(PWM_BASE + PWM_CNT(i), pwm_data.cnt[i]);
+ }
+}
+
static int sys_pwr_domain_suspend(void)
{
uint32_t wait_cnt = 0;
@@ -853,8 +916,7 @@
}
mmio_setbits_32(PMU_BASE + PMU_PWRDN_CON, BIT(PMU_SCU_B_PWRDWN_EN));
- /* TODO: Wait SoC to cut off the logic_center, switch the gpio mode */
- mmio_write_32(PMUGRF_BASE + PMUGRF_GPIO0A_IOMUX, GPIO0A6_IOMUX_GPIO);
+ save_pwms();
return 0;
}
@@ -864,8 +926,7 @@
uint32_t wait_cnt = 0;
uint32_t status = 0;
- /* TODO: switch the pwm mode */
- mmio_write_32(PMUGRF_BASE + PMUGRF_GPIO0A_IOMUX, GPIO0A6_IOMUX_PWM);
+ restore_pwms();
pmu_sgrf_rst_hld();
diff --git a/plat/rockchip/rk3399/drivers/pmu/pmu.h b/plat/rockchip/rk3399/drivers/pmu/pmu.h
index 797282f..ddb1c16 100644
--- a/plat/rockchip/rk3399/drivers/pmu/pmu.h
+++ b/plat/rockchip/rk3399/drivers/pmu/pmu.h
@@ -810,10 +810,20 @@
#define PMUGRF_GPIO0A_IOMUX 0x00
#define PMUGRF_GPIO1A_IOMUX 0x10
+#define PMUGRF_GPIO1C_IOMUX 0x18
+
#define AP_PWROFF 0x0a
+
#define GPIO0A6_IOMUX_GPIO BITS_WITH_WMASK(0, 3, 12)
#define GPIO0A6_IOMUX_PWM BITS_WITH_WMASK(1, 3, 12)
+#define GPIO1C3_IOMUX_GPIO BITS_WITH_WMASK(0, 3, 6)
+#define GPIO1C3_IOMUX_PWM BITS_WITH_WMASK(1, 3, 6)
+#define GPIO4C2_IOMUX_GPIO BITS_WITH_WMASK(0, 3, 4)
+#define GPIO4C2_IOMUX_PWM BITS_WITH_WMASK(1, 3, 4)
+#define GPIO4C6_IOMUX_GPIO BITS_WITH_WMASK(0, 3, 12)
+#define GPIO4C6_IOMUX_PWM BITS_WITH_WMASK(1, 3, 12)
#define GPIO1A6_IOMUX BITS_WITH_WMASK(0, 3, 12)
+
#define TSADC_INT_PIN 38
#define CORES_PM_DISABLE 0x0
#define CPU_AXI_QOS_ID_COREID 0x00
@@ -867,6 +877,8 @@
#define MAX_WAIT_COUNT 1000
#define GRF_SOC_CON4 0x0e210
+#define GRF_GPIO4C_IOMUX 0x0e028
+
#define PMUGRF_SOC_CON0 0x0180
#define CCI_FORCE_WAKEUP WMSK_BIT(8)
@@ -901,6 +913,15 @@
mmio_write_32(base + CPU_AXI_QOS_EXTCONTROL, array[6]); \
} while (0)
+/* there are 4 PWMs on rk3399 */
+struct pwm_data_s {
+ uint32_t iomux_bitmask;
+ uint64_t cnt[4];
+ uint64_t duty[4];
+ uint64_t period[4];
+ uint64_t ctrl[4];
+};
+
struct pmu_slpdata_s {
uint32_t cci_m0_qos[CPU_AXI_QOS_NUM_REGS];
uint32_t cci_m1_qos[CPU_AXI_QOS_NUM_REGS];