commit a80ea27d7ef3b06c919622c17a19d28466f12199
author Nithin G <nithing@amd.com> Tue Apr 23 12:41:00 2024 +0530
committer Maheedhar Bollapalli <maheedharsai.bollapalli@amd.com> Sun Mar 09 22:02:53 2025 +0530
tree 4deaac1652340440c062c0f28624dfb739be23cf
parent 87f89f9abfab23b31ea0de5b20017da8c090afd1

fix(arm-drivers): typecast expression to match data type

This corrects the MISRA violation C2012-10.6:
The value of a composite expression shall not be assigned to
an object with wider essential type.
Explicitly type casted to match the data type of composite
expression.

Change-Id: I2ec044ff7fd7a8d0cdc8db5f71f30872fb8d9e81
Signed-off-by: Nithin G <nithing@amd.com>
Signed-off-by: Maheedhar Bollapalli <maheedharsai.bollapalli@amd.com>

drivers/arm/gic/v2/gicdv2_helpers.c

diff --git a/drivers/arm/gic/v2/gicdv2_helpers.c b/drivers/arm/gic/v2/gicdv2_helpers.c
index db9ba87..2f3f7f8 100644
--- a/drivers/arm/gic/v2/gicdv2_helpers.c
+++ b/drivers/arm/gic/v2/gicdv2_helpers.c
@@ -8,6 +8,7 @@
 
 #include <drivers/arm/gic_common.h>
 #include <lib/mmio.h>
+#include <lib/utils_def.h>
 
 #include "../common/gic_common_private.h"
 
@@ -256,7 +257,7 @@
 	unsigned int bit_num = id & ((1U << IGROUPR_SHIFT) - 1U);
 	unsigned int reg_val = gicd_read_igroupr(base, id);
 
-	gicd_write_igroupr(base, id, reg_val | (1U << bit_num));
+	gicd_write_igroupr(base, id, reg_val | BIT_32(bit_num));
 }
 
 void gicd_clr_igroupr(uintptr_t base, unsigned int id)
@@ -264,35 +265,35 @@
 	unsigned int bit_num = id & ((1U << IGROUPR_SHIFT) - 1U);
 	unsigned int reg_val = gicd_read_igroupr(base, id);
 
-	gicd_write_igroupr(base, id, reg_val & ~(1U << bit_num));
+	gicd_write_igroupr(base, id, reg_val & ~BIT_32(bit_num));
 }
 
 void gicd_set_isenabler(uintptr_t base, unsigned int id)
 {
 	unsigned int bit_num = id & ((1U << ISENABLER_SHIFT) - 1U);
 
-	gicd_write_isenabler(base, id, (1U << bit_num));
+	gicd_write_isenabler(base, id, BIT_32(bit_num));
 }
 
 void gicd_set_icenabler(uintptr_t base, unsigned int id)
 {
 	unsigned int bit_num = id & ((1U << ICENABLER_SHIFT) - 1U);
 
-	gicd_write_icenabler(base, id, (1U << bit_num));
+	gicd_write_icenabler(base, id, BIT_32(bit_num));
 }
 
 void gicd_set_ispendr(uintptr_t base, unsigned int id)
 {
 	unsigned int bit_num = id & ((1U << ISPENDR_SHIFT) - 1U);
 
-	gicd_write_ispendr(base, id, (1U << bit_num));
+	gicd_write_ispendr(base, id, BIT_32(bit_num));
 }
 
 void gicd_set_icpendr(uintptr_t base, unsigned int id)
 {
 	unsigned int bit_num = id & ((1U << ICPENDR_SHIFT) - 1U);
 
-	gicd_write_icpendr(base, id, (1U << bit_num));
+	gicd_write_icpendr(base, id, BIT_32(bit_num));
 }
 
 unsigned int gicd_get_isactiver(uintptr_t base, unsigned int id)
@@ -307,14 +308,14 @@
 {
 	unsigned int bit_num = id & ((1U << ISACTIVER_SHIFT) - 1U);
 
-	gicd_write_isactiver(base, id, (1U << bit_num));
+	gicd_write_isactiver(base, id, BIT_32(bit_num));
 }
 
 void gicd_set_icactiver(uintptr_t base, unsigned int id)
 {
 	unsigned int bit_num = id & ((1U << ICACTIVER_SHIFT) - 1U);
 
-	gicd_write_icactiver(base, id, (1U << bit_num));
+	gicd_write_icactiver(base, id, BIT_32(bit_num));
 }
 
 void gicd_set_ipriorityr(uintptr_t base, unsigned int id, unsigned int pri)