fix(xilinx): resolve misra rule 4.6 violations
Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.4.6:
- Typedefs that indicate size and signedness should be used in
place of the basic numerical types.
- Fix:
- Used typedefs that indicate size and signedness in place of basic
numerical types and updated return type of function wherever needed.
Change-Id: Ifde2379ee3f9d5ab30ef695d99f59591af575aba
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>
diff --git a/plat/xilinx/common/include/ipi.h b/plat/xilinx/common/include/ipi.h
index 71c06c3..c628496 100644
--- a/plat/xilinx/common/include/ipi.h
+++ b/plat/xilinx/common/include/ipi.h
@@ -38,9 +38,9 @@
/* structure to maintain IPI configuration information */
struct ipi_config {
- unsigned int ipi_bit_mask;
- unsigned int ipi_reg_base;
- unsigned char secure_only;
+ uint32_t ipi_bit_mask;
+ uint32_t ipi_reg_base;
+ uint8_t secure_only;
};
/*********************************************************************
@@ -52,7 +52,7 @@
uint32_t total_ipi);
/* Validate IPI mailbox access */
-int ipi_mb_validate(uint32_t local, uint32_t remote, unsigned int is_secure);
+int32_t ipi_mb_validate(uint32_t local, uint32_t remote, uint32_t is_secure);
/* Open the IPI mailbox */
void ipi_mb_open(uint32_t local, uint32_t remote);
diff --git a/plat/xilinx/common/ipi.c b/plat/xilinx/common/ipi.c
index 18ae096..8dc6da0 100644
--- a/plat/xilinx/common/ipi.c
+++ b/plat/xilinx/common/ipi.c
@@ -67,12 +67,12 @@
* Return: - 1 if within range, 0 if not.
*
*/
-static inline int is_ipi_mb_within_range(uint32_t local, uint32_t remote)
+static inline uint32_t is_ipi_mb_within_range(uint32_t local, uint32_t remote)
{
- int ret = 1;
+ uint32_t ret = 1U;
if ((remote >= ipi_total) || (local >= ipi_total)) {
- ret = 0;
+ ret = 0U;
}
return ret;
@@ -87,11 +87,11 @@
* Return: 0 success, negative value for errors.
*
*/
-int ipi_mb_validate(uint32_t local, uint32_t remote, unsigned int is_secure)
+int32_t ipi_mb_validate(uint32_t local, uint32_t remote, uint32_t is_secure)
{
- int ret = 0;
+ int32_t ret = 0;
- if (is_ipi_mb_within_range(local, remote) == 0) {
+ if (is_ipi_mb_within_range(local, remote) == 0U) {
ret = -EINVAL;
} else if (IPI_IS_SECURE(local) && (is_secure == 0U)) {
ret = -EPERM;