tree fcca63549f0f8c7ab15e706c6995de38aa2290d0
parent 80e264b03a2db32719628c52be676bfd74b0448d
author Justin Chadwell <justin.chadwell@arm.com> 1568730110 +0100
committer Madhukar Pappireddy <madhukar.pappireddy@arm.com> 1574175196 -0600

Enable -Wshadow always

Variable shadowing is, according to the C standard, permitted and valid
behaviour. However, allowing a local variable to take the same name as a
global one can cause confusion and can make refactoring and bug hunting
more difficult.

This patch moves -Wshadow from WARNING2 into the general warning group
so it is always used. It also fixes all warnings that this introduces
by simply renaming the local variable to a new name

Change-Id: I6b71bdce6580c6e58b5e0b41e4704ab0aa38576e
Signed-off-by: Justin Chadwell <justin.chadwell@arm.com>