fix(xilinx): resolve misra rule 2.7 violations
Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.2.7:
- There should be no unused parameters in functions.
- Fix:
- Type casted unused parameters to void.
Change-Id: I940109631dbabfbd960c1bc7b183cf865ff312c9
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>
diff --git a/plat/xilinx/common/pm_service/pm_api_sys.c b/plat/xilinx/common/pm_service/pm_api_sys.c
index f120b96..4390b55 100644
--- a/plat/xilinx/common/pm_service/pm_api_sys.c
+++ b/plat/xilinx/common/pm_service/pm_api_sys.c
@@ -163,8 +163,7 @@
/* Send request to the PLM */
PM_PACK_PAYLOAD6(payload, LIBPM_MODULE_ID, flag, PM_SELF_SUSPEND,
- proc->node_id, latency, state, address,
- (address >> 32));
+ nid, latency, state, address, (address >> 32));
ret = pm_ipi_send_sync(proc, payload, NULL, 0);
exit_label:
@@ -280,6 +279,13 @@
{
enum pm_ret_status ret = PM_RET_SUCCESS;
+ /*
+ * Typecasting to void to intentionally retain the variable and avoid
+ * MISRA violation for unused parameters. This may be used in the
+ * future if callbacks to a secure target are required.
+ */
+ (void)flag;
+
/* Return if interrupt is not from PMU */
if (pm_ipi_irq_status(primary_proc) != 0U) {
diff --git a/plat/xilinx/versal/plat_psci.c b/plat/xilinx/versal/plat_psci.c
index 032339f..1c365b4 100644
--- a/plat/xilinx/versal/plat_psci.c
+++ b/plat/xilinx/versal/plat_psci.c
@@ -136,6 +136,13 @@
static void versal_pwr_domain_on_finish(const psci_power_state_t *target_state)
{
+ /*
+ * Typecasting to void to intentionally retain the variable and avoid
+ * MISRA violation for unused parameters. This may be used in the
+ * future if specific action is required based on CPU power state.
+ */
+ (void)target_state;
+
/* Enable the gic cpu interface */
plat_versal_gic_pcpu_init();