commit 046e1f12776e9cee933117a2753f4f6694d95b53
author Abdul Halim, Muhammad Hadi Asyrafi <muhammad.hadi.asyrafi.abdul.halim@intel.com> Wed Feb 12 19:57:44 2020 +0800
committer Abdul Halim, Muhammad Hadi Asyrafi <muhammad.hadi.asyrafi.abdul.halim@intel.com> Sat Oct 24 11:00:42 2020 +0800
tree d7c0de4e80b7c2aa5f79a1aeab2ee473be2b26c2
parent 99b5e1645dfd837d3d1197df7f04ab1c2259a66a

intel: common: Improve readability of mailbox read response

Rename variables to improve readability of mailbox read response and
mailbox poll response flow.

Signed-off-by: Abdul Halim, Muhammad Hadi Asyrafi <muhammad.hadi.asyrafi.abdul.halim@intel.com>
Change-Id: Icd33ff1d2abb28eeead15e4eb9c7f9629f8cb402

plat/intel/soc/common/soc/socfpga_mailbox.c

diff --git a/plat/intel/soc/common/soc/socfpga_mailbox.c b/plat/intel/soc/common/soc/socfpga_mailbox.c
index 39b63c9..4f02b69 100644
--- a/plat/intel/soc/common/soc/socfpga_mailbox.c
+++ b/plat/intel/soc/common/soc/socfpga_mailbox.c
@@ -39,9 +39,10 @@
 {
 	int rin = 0;
 	int rout = 0;
-	int response_length = 0;
-	int resp = 0;
+	int mbox_resp_len = 0;
+	int resp_data = 0;
 	int total_resp_len = 0;
+	uint32_t *resp_buf = response;
 
 	if (mmio_read_32(MBOX_OFFSET + MBOX_DOORBELL_FROM_SDM))
 		mmio_write_32(MBOX_OFFSET + MBOX_DOORBELL_FROM_SDM, 0);
@@ -50,31 +51,31 @@
 	rout = mmio_read_32(MBOX_OFFSET + MBOX_ROUT);
 
 	if (rout != rin) {
-		resp = mmio_read_32(MBOX_OFFSET +
+		resp_data = mmio_read_32(MBOX_OFFSET +
 				    MBOX_RESP_BUFFER + ((rout++)*4));
 
 		rout %= MBOX_RESP_BUFFER_SIZE;
 		mmio_write_32(MBOX_OFFSET + MBOX_ROUT, rout);
 
-		if (MBOX_RESP_CLIENT_ID(resp) != MBOX_ATF_CLIENT_ID ||
-		   MBOX_RESP_JOB_ID(resp) != job_id) {
+		if (MBOX_RESP_CLIENT_ID(resp_data) != MBOX_ATF_CLIENT_ID ||
+		   MBOX_RESP_JOB_ID(resp_data) != job_id) {
 			return MBOX_WRONG_ID;
 		}
 
-		if (MBOX_RESP_ERR(resp) > 0) {
-			INFO("Error in response: %x\n", resp);
-			return -resp;
+		if (MBOX_RESP_ERR(resp_data) > 0) {
+			INFO("Error in response: %x\n", resp_data);
+			return -resp_data;
 		}
-		response_length = MBOX_RESP_LEN(resp);
+		mbox_resp_len = MBOX_RESP_LEN(resp_data);
 
-		while (response_length) {
+		while (mbox_resp_len > 0) {
 
-			response_length--;
-			resp = mmio_read_32(MBOX_OFFSET +
+			mbox_resp_len--;
+			resp_data = mmio_read_32(MBOX_OFFSET +
 						MBOX_RESP_BUFFER +
 						(rout)*4);
-			if (response && resp_len) {
-				*(response + total_resp_len) = resp;
+			if (resp_buf && resp_len) {
+				*(resp_buf + total_resp_len) = resp_data;
 				resp_len--;
 				total_resp_len++;
 			}
@@ -95,9 +96,10 @@
 	int timeout = 0xFFFFFF;
 	int rin = 0;
 	int rout = 0;
-	int response_length = 0;
-	int resp = 0;
+	int mbox_resp_len = 0;
+	int resp_data = 0;
 	int total_resp_len = 0;
+	uint32_t *resp_buf = response;
 
 	while (1) {
 
@@ -132,29 +134,30 @@
 		rout = mmio_read_32(MBOX_OFFSET + MBOX_ROUT);
 
 		while (rout != rin) {
-			resp = mmio_read_32(MBOX_OFFSET +
+			resp_data = mmio_read_32(MBOX_OFFSET +
 					    MBOX_RESP_BUFFER + ((rout++)*4));
 
 			rout %= MBOX_RESP_BUFFER_SIZE;
 			mmio_write_32(MBOX_OFFSET + MBOX_ROUT, rout);
 
-			if (MBOX_RESP_CLIENT_ID(resp) != MBOX_ATF_CLIENT_ID ||
-			   MBOX_RESP_JOB_ID(resp) != job_id)
+			if (MBOX_RESP_CLIENT_ID(resp_data) != MBOX_ATF_CLIENT_ID
+				|| MBOX_RESP_JOB_ID(resp_data) != job_id)
 				continue;
 
-			if (MBOX_RESP_ERR(resp) > 0) {
-				INFO("Error in response: %x\n", resp);
-				return -MBOX_RESP_ERR(resp);
+			if (MBOX_RESP_ERR(resp_data) > 0) {
+				INFO("Error in response: %x\n", resp_data);
+				return -MBOX_RESP_ERR(resp_data);
 			}
-			response_length = MBOX_RESP_LEN(resp);
+			mbox_resp_len = MBOX_RESP_LEN(resp_data);
 
-			while (response_length) {
-				response_length--;
-				resp = mmio_read_32(MBOX_OFFSET +
+			while (mbox_resp_len > 0) {
+				mbox_resp_len--;
+				resp_data = mmio_read_32(MBOX_OFFSET +
 							MBOX_RESP_BUFFER +
 							(rout)*4);
-				if (response && resp_len) {
-					*(response + total_resp_len) = resp;
+				if (resp_buf && resp_len) {
+					*(resp_buf + total_resp_len)
+							= resp_data;
 					resp_len--;
 					total_resp_len++;
 				}